Skip to content

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Oct 13, 2025

system ([#147423](https://github.com/rust-lang/rust/pull/147423)). There have also been a couple of
regressions. [#142390](https://github.com/rust-lang/rust/pull/142390) introduced regressions of `check`
builds across the board. The largest regression (18%) is from an incremental opt build of a secondary
artificial stress test, so we deemed it acceptable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also incremental opt is not a default config IIRC

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by default config?

Copy link
Member

@lqd lqd Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something that cargo does out of the box. You need to opt into incremental for release builds IIRC, since codegen is worse. It’s not a configuration that people would usually use.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and I think the same is true for Check Full and Debug Full because Check/Debug are incremental by default. I've previously wondered if we should account for this somehow, possibly even removing some of the combinations.

Copy link
Member Author

@Kobzol Kobzol Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do personally use incremental release builds from time to time, and I do use them almost all the time when building the compiler itself. Non-incremental check/debug is also very common in CI pipelines, because there incremental builds are disabled in 99.9% of cases, and most people just do cargo check/build to have the build finish faster.

@Kobzol Kobzol added this pull request to the merge queue Oct 14, 2025
Merged via the queue into rust-lang:master with commit a4d47f7 Oct 14, 2025
13 checks passed
@Kobzol Kobzol deleted the triage-2025-10-13 branch October 14, 2025 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants