Skip to content

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Oct 14, 2025

So that we can run runtime benchmarks on ARM machines.

@Kobzol Kobzol requested a review from Jamesbarford October 14, 2025 20:35
Copy link
Contributor

@Jamesbarford Jamesbarford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a couple of suggestions about the casing of the SQL keywords in the statements. Rather than comment on each one could you please go through capitalising the keywords. It's easier to read and also distinguishes the old queries from the new ones we've written.

@Kobzol
Copy link
Member Author

Kobzol commented Oct 17, 2025

It's easier to read and also distinguishes the old queries from the new ones we've written.

I agree it's easier to read, but I'm not sure what do you mean by the distinction. I have not added any new queries apart from migrations in this PR. Do you suggest to automatically capitalize SQL in any query that we modify from now on?

@Jamesbarford
Copy link
Contributor

It's easier to read and also distinguishes the old queries from the new ones we've written.

I agree it's easier to read, but I'm not sure what do you mean by the distinction. I have not added any new queries apart from migrations in this PR. Do you suggest to automatically capitalize SQL in any query that we modify from now on?

Yes I think we should capitalize SQL in queries we modify. Whay I mean by "distinction" is that the old queries are lower case so it's easy to see what is old and what is new - though this is subjective

@Kobzol
Copy link
Member Author

Kobzol commented Oct 19, 2025

I don't think that we necessarily need to distinguish queries, there is not really any specific point where we could say that a query is "old" or "new"; this PR is not even primarily related to the job queue.

But I agree that it's a reasonable drive-by refactoring, so I went ahead and capitalized the modified queries.

@Kobzol Kobzol requested a review from Jamesbarford October 20, 2025 12:35
Copy link
Contributor

@Jamesbarford Jamesbarford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Kobzol Kobzol added this pull request to the merge queue Oct 21, 2025
Merged via the queue into rust-lang:master with commit 58dceae Oct 21, 2025
13 of 14 checks passed
@Kobzol Kobzol deleted the runtime-benchmarks-target branch October 21, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants