Skip to content

Add total accumulated change to the Aggregations tab #2289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2025
Merged

Add total accumulated change to the Aggregations tab #2289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions site/frontend/src/pages/compare/compile/aggregations.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ import SummaryTable from "../summary/summary-table.vue";
import {createPersistedRef} from "../../../storage";
import {PREF_AGGREGATIONS_OPENED} from "../prefs";
import {CompileTestCase} from "./common";
import {computed} from "vue";
import {diffClass, formatPercentChange} from "../shared";
import Tooltip from "../tooltip.vue";
const props = defineProps<{
cases: TestCaseComparison<CompileTestCase>[];
Expand All @@ -24,6 +27,13 @@ function calculateSummary(
}
const opened = createPersistedRef(PREF_AGGREGATIONS_OPENED);
const totalBefore = computed(() =>
props.cases.map((c) => c.datumA).reduce((acc, v) => acc + v, 0)
);
const totalAfter = computed(() =>
props.cases.map((c) => c.datumB).reduce((acc, v) => acc + v, 0)
);
</script>

<template>
Expand All @@ -32,6 +42,17 @@ const opened = createPersistedRef(PREF_AGGREGATIONS_OPENED);
<template #label>Aggregations</template>
<template #content>
<div>
<div>
Total accumulated change:
<span :class="diffClass(totalAfter - totalBefore)">
{{ formatPercentChange(totalBefore, totalAfter) }}</span
>
<Tooltip style="margin-left: 1em">
The total accumulated change in the measured metric across all
visible benchmarks. Computed by summing the value of the metric
for all visible benchmarks and comparing the before/after sum.
</Tooltip>
</div>
<div class="aggregation-section">
<div class="header">Profile</div>
<div class="groups">
Expand Down
Loading