Cleaned up tests by bringing objects under mini_core into scope
#639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoyo
reviewed
Feb 26, 2025
madhav-madhusoodanan
force-pushed
the
test_update_mini_core
branch
4 times, most recently
from
535d7e9 to
5686361
Compare
| } | ||
|
|
||
| pub mod intrinsics { | ||
| #[rustc_intrinsic] |
Contributor
Author
There was a problem hiding this comment.
@antoyo is the #[rustc_nounwind] annotation needed for functions within the intrinsics module?
madhav-madhusoodanan
changed the title
mini_core into scopemini_core into scope
antoyo
reviewed
Mar 7, 2025
Contributor
antoyo
left a comment
antoyo
left a comment
There was a problem hiding this comment.
There's a few more stuff to clean up.
Apart from that, it looks good.
Thanks!
madhav-madhusoodanan
force-pushed
the
test_update_mini_core
branch
from
5686361 to
40367a9
Compare
madhav-madhusoodanan
force-pushed
the
test_update_mini_core
branch
from
40367a9 to
572da5c
Compare
antoyo
approved these changes
Mar 8, 2025
Contributor
|
Thanks a lot for your contribution! |
Contributor
Author
|
Thank you so much for taking the time to explain me why certain components (annotations, etc) needed to be removed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I've cleaned up test files that did not reuse the
mini_corelibrary in example/mini_core.rs.I've updated example/mini_core.rs to bring in the
Receivertrait and the implementations ofAdd,SubandMulfor some more types that were required in the tests.Have added
fn fflushandstdouttolibcinmini_core.Related Issue