Raise command signal to the current process #698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
force-pushed
the
signal
branch
3 times, most recently
from
4f701d3 to
b6082d1
Compare
antoyo
reviewed
Jun 6, 2025
build_system/src/rust_tools.rs
Outdated
| #[cfg(unix)] | ||
| { | ||
| let error = crate::utils::get_command_inner(input, None, Some(env)).exec(); | ||
| eprintln!("Command failed: {error:?}"); |
There was a problem hiding this comment.
I would rephrase the error to make this clear that it's the execvp syscall that failed.
|
Nice work! |
… they exit because of a signal, it will be displayed at the top level
|
Updated error message. |
|
Added docs too. |
|
Thanks a lot for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #496.