Add missing line to use_field_init_shorthand "true" example
#5523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last declaration (`let b = ...`) is where all the difference between the "false" and "true" cases lies, but it was omitted from the "true" example for unknown reasons. Assuming it was by accident, this patch adds the last line from the "false" example to the "true" example, formatted as it would have been with `use_field_init_shorthand = true`.
|
Thanks but I'm going to close for the reasons discussed in #5522 (comment) as I want to avoid any additional toggling we've been doing in the existing config snippet structure (we've done this a bit but almost always find what seems more clear to one person actually muddies things for someone else) |
|
Ok, thanks. |
|
@calebcartwright I wonder if you might have misunderstood @mqudsi's suggest here? Or else I'm misunderstanding your reply. This PR wasn't asking for any behavioral changes at all, but just correcting a bug in the shown example output of (I noticed the same bug in that example myself today, hence why I'm here.) |
|
The docs were updated in #6562 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last declaration (
let b = ...) is where all the difference between the"false" and "true" cases lies, but it was omitted from the "true" example for
unknown reasons.
Assuming it was by accident, this patch adds the last line from the "false"
example to the "true" example, formatted as it would have been with
use_field_init_shorthand = true.