feat: use semver to match required version
#6066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytmimi
reviewed
Feb 9, 2024
Contributor
ytmimi
left a comment
ytmimi
left a comment
There was a problem hiding this comment.
Thanks for working on this one so soon. I'll be a little busy this coming weekend so I wanted to at least get my initial review done now. Good stuff so far!
…n' of github.com:ologbonowiwi/rustfmt into feat/rust-lang#6063/use-semver-to-check-required-version
Contributor
Author
|
changes addressed @ytmimi. Thanks for the quick feedback 😄 |
ytmimi
reviewed
Feb 9, 2024
Contributor
ytmimi
left a comment
ytmimi
left a comment
There was a problem hiding this comment.
A few more notes, but we're moving in the right direction
Co-authored-by: Yacin Tmimi <[email protected]>
…n' of github.com:ologbonowiwi/rustfmt into feat/rust-lang#6063/use-semver-to-check-required-version
…lang#6063/use-semver-to-check-required-version
Co-authored-by: Yacin Tmimi <[email protected]>
…n' of github.com:ologbonowiwi/rustfmt into feat/rust-lang#6063/use-semver-to-check-required-version
ytmimi
reviewed
Oct 10, 2024
ytmimi
reviewed
Oct 10, 2024
wesleymatosdev
force-pushed
the
feat/#6063/use-semver-to-check-required-version
branch
from
ea85318 to
4e15dbf
Compare
ytmimi
reviewed
Oct 14, 2024
Contributor
ytmimi
left a comment
ytmimi
left a comment
There was a problem hiding this comment.
A minor note about rewording the #### Multiple version to match docs and maybe adding another test case for the wildcard match.
Contributor
Author
|
appreciate the feedback and patience @ytmimi, great rewording on those docs. lmk if there's anything else 🎉 |
ytmimi
approved these changes
Feb 26, 2025
Contributor
ytmimi
left a comment
ytmimi
left a comment
There was a problem hiding this comment.
Just re-reviewed the changes. Thanks again for sticking with this 🎉
ytmimi
added
release-notes
wesleymatosdev
deleted the
feat/#6063/use-semver-to-check-required-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required_versionsemversemverto compare versionssemverrequired_versionparsing manuallyCloses #6063