Skip to content

Non-panicking fmt::Display for FileName #6328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2024
Merged

Non-panicking fmt::Display for FileName #6328

merged 1 commit into from
Sep 16, 2024

Conversation

Rawk
Copy link
Contributor

@Rawk Rawk commented Sep 16, 2024

Avoid unwrap() by using infallible std::path::Path::display().

@Rawk Rawk force-pushed the no-panic-disp-filename branch from 7b3b5e6 to 14f3d2c Compare September 16, 2024 13:05
@Rawk Rawk force-pushed the no-panic-disp-filename branch from 14f3d2c to 8bd6cfe Compare September 16, 2024 13:07
@Rawk
Copy link
Contributor Author

Rawk commented Sep 16, 2024

Changed some more places where std::path::Path::display() can be used.

ytmimi
ytmimi approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@ytmimi ytmimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ytmimi ytmimi merged commit 5230e8f into rust-lang:master Sep 16, 2024
26 checks passed
@Rawk Rawk deleted the no-panic-disp-filename branch September 16, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ytmimi ytmimi ytmimi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Rawk @ytmimi @rustbot