Skip to content

Conversation

camsteffen
Copy link
Contributor

This ultimately re-uses Shape::exceeds_max_width_error more to be a tad DRYer.

@ytmimi
Copy link
Contributor

ytmimi commented Dec 3, 2024

Would it be simpler to have wrap_str return Result<String, ExceedsMaxWidthError>?

@camsteffen
Copy link
Contributor Author

I like how borrowing makes it clear that the string isn't modified personally. But that would be a more conservative change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants