fix: wrap_comments creating invalid code blocks #6417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Can you add the input from #5244 as a test case as well? |
|
Yep, changed the tests to those. |
ytmimi
reviewed
Dec 12, 2024
|
Ran our Diff-Check and things look good |
ytmimi
approved these changes
Jan 21, 2025
ytmimi
added
release-notes
|
Thanks for the help on this, and congrats on your first contribution to rustfmt 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5244
This PR fixes the issue in
#6416(duplicate of #5244), I have added both the before and after case of the formatting intests/.Edit (ytmimi): I updated the description