Skip to content

Conversation

ytmimi
Copy link
Contributor

@ytmimi ytmimi commented Feb 12, 2025

Bumping the toolchain version as part of a git subtree push

current toolchain (nightly-2025-01-02):

  • 1.85.0-nightly (45d11e51b 2025-01-01)

latest toolchain (nightly-2025-02-12):

  • 1.86.0-nightly (92bedea1c 2025-02-11)

jieyouxu and others added 12 commits January 7, 2025 20:49
Only treat plain literal patterns as short

See rust-lang/rust#134228 (comment) and rust-lang/rust#134228 (comment) for context. We never wanted to treat const blocks and paths as short, only plain literals.

I don't know how to write a test for this, it.s not clear to me how the short pattern check actually affects the formatting
Bumping the toolchain version as part of a git subtree push

current toolchain (nightly-2025-01-02):
  - 1.85.0-nightly (45d11e51b 2025-01-01)

latest toolchain (nightly-2025-02-12):
  - 1.86.0-nightly (92bedea1c 2025-02-11)
@ytmimi
Copy link
Contributor Author

ytmimi commented Feb 12, 2025

Diff-Check

Edit: Diff-Check Failed ❌ because of the change to revert overflow_delimited_expr in the 2024 edition.

Diff in /tmp/rust-lang-rust-kcfe0P9o/compiler/rustc_monomorphize/src/mono_checks/move_check.rs:162:
             // but correct span? This would make the lint at least accept crate-level lint attributes.
             return;
         };
-        self.tcx.emit_node_span_lint(
-            LARGE_ASSIGNMENTS,
-            lint_root,
+        self.tcx.emit_node_span_lint(LARGE_ASSIGNMENTS, lint_root, span, LargeAssignmentsLint {
             span,
-            LargeAssignmentsLint { span, size: too_large_size.bytes(), limit: limit as u64 },
-        );
+            size: too_large_size.bytes(),
+            limit: limit as u64,
+        });
         self.move_size_spans.push(span);
     }
 }

@ytmimi
Copy link
Contributor Author

ytmimi commented Mar 18, 2025

Closing this since there have been additional rustc changes since this was opened, and I've also merged other PRs since then too. I'll open up another PR for the sync.

@ytmimi ytmimi closed this Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants