-
Notifications
You must be signed in to change notification settings - Fork 962
subtree-push nightly-2025-02-12 #6476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only treat plain literal patterns as short See rust-lang/rust#134228 (comment) and rust-lang/rust#134228 (comment) for context. We never wanted to treat const blocks and paths as short, only plain literals. I don't know how to write a test for this, it.s not clear to me how the short pattern check actually affects the formatting
Bumping the toolchain version as part of a git subtree push current toolchain (nightly-2025-01-02): - 1.85.0-nightly (45d11e51b 2025-01-01) latest toolchain (nightly-2025-02-12): - 1.86.0-nightly (92bedea1c 2025-02-11)
Edit: Diff-Check Failed ❌ because of the change to revert Diff in /tmp/rust-lang-rust-kcfe0P9o/compiler/rustc_monomorphize/src/mono_checks/move_check.rs:162:
// but correct span? This would make the lint at least accept crate-level lint attributes.
return;
};
- self.tcx.emit_node_span_lint(
- LARGE_ASSIGNMENTS,
- lint_root,
+ self.tcx.emit_node_span_lint(LARGE_ASSIGNMENTS, lint_root, span, LargeAssignmentsLint {
span,
- LargeAssignmentsLint { span, size: too_large_size.bytes(), limit: limit as u64 },
- );
+ size: too_large_size.bytes(),
+ limit: limit as u64,
+ });
self.move_size_spans.push(span);
}
} |
Closing this since there have been additional rustc changes since this was opened, and I've also merged other PRs since then too. I'll open up another PR for the sync. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping the toolchain version as part of a git subtree push
current toolchain (nightly-2025-01-02):
latest toolchain (nightly-2025-02-12):