docs: clarify the editions behavior and it's consequences on formatting #6486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytmimi
reviewed
Feb 25, 2025
ytmimi
reviewed
Feb 25, 2025
ytmimi
reviewed
Feb 25, 2025
karolzwolak
force-pushed
the
editions-doc-fix-6483
branch
from
7b9fba8 to
aa2f3ec
Compare
Member
Author
|
Okay, I think I addressed everything, let me know if there is anything else to tweak. |
ytmimi
reviewed
Feb 25, 2025
ytmimi
reviewed
Feb 25, 2025
karolzwolak
force-pushed
the
editions-doc-fix-6483
branch
2 times, most recently
from
3085143 to
21852b6
Compare
Member
Author
|
I fixed those 2 issues you had and I fast-forwarded the branch. |
ytmimi
requested changes
Feb 26, 2025
Contributor
ytmimi
left a comment
ytmimi
left a comment
There was a problem hiding this comment.
Thanks so much for the edits. Please see my suggestions for additional updates to the docs.
Co-authored-by: Yacin Tmimi <[email protected]>
karolzwolak
force-pushed
the
editions-doc-fix-6483
branch
from
57e11a7 to
ecf3b62
Compare
karolzwolak
force-pushed
the
editions-doc-fix-6483
branch
from
afab171 to
4f89165
Compare
ytmimi
reviewed
Feb 27, 2025
Member
Author
|
If you have no further suggestions, should I squash the changes into a single commit? |
Contributor
If you'd like, but I can squash and merge too if that's easier. |
ytmimi
approved these changes
Feb 27, 2025
Member
Author
|
I could do it, but I'm not sure on the semantics of the squashed commit (the name and description), so if you can do it, go ahead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
rustfmtdirectly on a project targeting the 2024 edition, the formatting differs fromcargo fmtbecauserustfmtdefaults to the 2015 edition. This discrepancy causes inconsistencies, especially when tools like editors automatically runrustfmton save, leading to files being reformatted to the 2015 edition style.I tried to explain this behavior concisely in the docs.
Fixes #6483.