Skip to content

Conversation

BenjaminBrienen
Copy link

Simply run cargo clippy --fix.

@ytmimi ytmimi closed this Mar 30, 2025
@BenjaminBrienen
Copy link
Author

Sorry if this seemed like spam. Is this against some process you have? @ytmimi

@ytmimi
Copy link
Contributor

ytmimi commented Mar 31, 2025

We don't have a policy against clippy PRs, but they're extremely low priority. From the commit messages it looks like you just blindly ran cargo clippy --fix and submitted the PR. I took a brief look at the diff and it seemed like a lot of changes were in test code which isn't that impactful and I'd rather avoid the churn if there isn't much of a benefit outside of "clippy said this was better".

@ytmimi
Copy link
Contributor

ytmimi commented Mar 31, 2025

That said, if there's an argument to be made for select changes that provide some measurable benefit then we'd be willing to accept those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants