Fix panic on blockquote #6684
Open
Fix panic on blockquote #6684
+23
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
approved these changes
Oct 8, 2025
Manishearth
suggested changes
Oct 8, 2025
|
|
||
| while chars.peek() == Some(&'>') { | ||
| chars.next(); | ||
| if chars.peek() == Some(&' ') { |
There was a problem hiding this comment.
it can be multiple spaces, yes?
There was a problem hiding this comment.
we should have tests for the nested blockquote code that include quotes with multiple spaces (if that does indeed work in rust's markdown)
There was a problem hiding this comment.
and if it's multiple spaces then we can't just do line[indent..] above, we actually need to count
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6660
Previously, when formatting comments containing blockquotes followed by comparison operators like
> >= >> >>= >>> >>>=, the code would panic withbyte index out of boundserror.The issue was in
itemized_block_quote_startfunction, which counted all>characters in non-alphanumeric prefix, treating operators like>=as nested blockquote markers. This caused the calculated indent to exceed the line length, leading to out-of-bounds indexing.Fixed by only recognizing valid Markdown blockquote syntax where each
>must be followed by a space (e.g.,> > text), which was the original intended behavior. Note that only the standard format with spaces is supported, alternative formats like>> text,> > text(multiple spaces), or>text(no space) are not recognized as blockquote markers.