Skip to content

Support formatting for lazy_static::lazy_static! #6690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 13, 2025
Merged

Support formatting for lazy_static::lazy_static! #6690

merged 4 commits into from
Oct 13, 2025
+194 −6

Conversation

shulaoda
Copy link
Contributor

closes #6287

Since this is special support for a specific crate macro, we should handle both forms — lazy_static! and lazy_static::lazy_static!.

fee1-dead
fee1-dead approved these changes Oct 10, 2025
View reviewed changes
Copy link
Member

@fee1-dead fee1-dead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to merge, @ytmimi thoughts?

@Manishearth
Copy link
Member

This technically impacts formatted code. I don't know what our decision matrix is for stuff like this.

Also, at this point I don't know if we need to fix it, lazy_static is somewhat deprecated since there are equivalent stdlib types.

@ytmimi
Copy link
Contributor

ytmimi commented Oct 10, 2025 •
edited
Loading

I think The changes to lazy_static::lazy_static! would need to be gated behind style_edition=2027.

@fee1-dead
Copy link
Member

I think The changes to lazy_static::lazy_static! would need to be gated behind style_edition=2027.

@shulaoda can you do this? I think it would be good to merge after.

@shulaoda shulaoda requested a review from fee1-dead October 13, 2025 02:40
fee1-dead
fee1-dead reviewed Oct 13, 2025
View reviewed changes
fee1-dead
fee1-dead approved these changes Oct 13, 2025
View reviewed changes
Copy link
Member

@fee1-dead fee1-dead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Manishearth Manishearth enabled auto-merge October 13, 2025 06:22
@Manishearth Manishearth merged commit 9e90cfb into rust-lang:master Oct 13, 2025
26 checks passed
@ytmimi ytmimi added the release-notes Needs an associated changelog entry label Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Manishearth Manishearth Manishearth approved these changes

@fee1-dead fee1-dead fee1-dead approved these changes

Assignees

No one assigned

Labels

release-notes Needs an associated changelog entry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Formatting inside the lazy_static! macro did not work when the macro is used with the crate name: lazy_static::lazy_static!

5 participants

@shulaoda @Manishearth @ytmimi @fee1-dead @rustbot