Skip to content

Conversation

shulaoda
Copy link
Contributor

It has been marked with #[allow(dead_code)] for four years, and since it’s no longer used, we should remove it.

@Manishearth Manishearth merged commit 0cf8543 into rust-lang:master Oct 11, 2025
26 checks passed
@shulaoda shulaoda deleted the 10-11-remove-unused-esm.rs branch October 11, 2025 09:24
@ytmimi
Copy link
Contributor

ytmimi commented Oct 13, 2025

FYI this was added to eventually support asm! macro formatting. I don't think it needed to be removed.

@Manishearth
Copy link
Member

I think it's small enough that we can dredge it up from the history if we need.

@shulaoda
Copy link
Contributor Author

FYI this was added to eventually support asm! macro formatting. I don't think it needed to be removed.

Since there’s no concrete implementation at the moment, we can revert it when we introduce the actual implementation in the future.

@ytmimi
Copy link
Contributor

ytmimi commented Oct 13, 2025

That's fine with me. I'm just giving you guys context for why it's there.

@Manishearth
Copy link
Member

Got it, thanks!

@ytmimi ytmimi changed the title Remove unused esm.rs Remove unused asm.rs Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants