Use Rust Diff Check Binary in CI #6770
Open
+40
−256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer needed since we're moving to the rust version.
Now we're calling our rust binary instead of our old shell script.
This will let us test the `check_diff` binary with different combinations of Rust language edition and rustfmt style_edition.
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #6751, which actually uses the check_diff rust binary in our CI and removes the
ci/check_diff.shscript we were running before.This PR also adds
language_editionandstyle_editionsupport similar to #6742 so that the CI job can be used to test different combinations of Rust language edition's and rustfmt style_edition to ensure that we're not introducing breaking changes across those different dimensions.r? @jieyouxu @Manishearth @calebcartwright