Skip to content

chore: use more workspace-wide configurations #4061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 25, 2024
Merged

chore: use more workspace-wide configurations #4061

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
72e2e76
build: use `workspace.package` properties in `Cargo.toml`
rami3l Oct 6, 2024
3d3d76f
style: introduce workspace-wide lint tables
rami3l Oct 24, 2024
80d4195
style: enable `clippy::print_std(err|out)` when applicable
rami3l Oct 24, 2024
c062350
style: enable `clippy::(dbg_macro|todo)` across the workspace
rami3l Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,11 @@ walkdir = "2"
[workspace.lints.rust]
rust_2018_idioms = "deny"

[workspace.lints.clippy]
# `dbg!()` and `todo!()` clearly shouldn't make it to production:
dbg_macro = "warn"
todo = "warn"

[lib]
name = "rustup"
path = "src/lib.rs"
Expand Down
7 changes: 5 additions & 2 deletions src/test/mock/clitools.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,8 +668,11 @@ impl Config {
println!("expected.ok: true");
print_indented("expected.stdout", stdout);
print_indented("expected.stderr", stderr);
dbg!(out.stdout == stdout);
dbg!(out.stderr == stderr);
#[allow(clippy::dbg_macro)]
{
dbg!(out.stdout == stdout);
dbg!(out.stderr == stderr);
}
panic!();
}
}
Expand Down
Loading