refactor: Simplify abstracted stdout/stderr #4517
Open
+43
−103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a lot of cases, `Process` will create a boxed `Writer` just then to create a `ColorableTerminal` from it. This bypasses some of those steps, simplifying the code.
rami3l
reviewed
Oct 7, 2025
src/process/filesource.rs
Outdated
|
|
||
| fn terminal(&self, process: &Process) -> ColorableTerminal { | ||
| ColorableTerminal::new(StreamSelector::TestWriter(self.clone()), process) | ||
| ColorableTerminal::test(self, process) |
There was a problem hiding this comment.
Question: is it true that this line has been changed here first and a second time in the following commit? Would that mean at least one of the commits are not compiling, thus violating the rules of atomic commits?
There was a problem hiding this comment.
You're right; I forgot to test my history edits.
There was a problem hiding this comment.
@epage Sorry, but I don't see the fix being applied here? I think .clone() is needed from the start if I'm not mistaken. Maybe you are not checking with the test feature on?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To write colored output on a locked stream, you had to:
process.stdout()to get aBox<dyn Writer>Writer::terminal(process)to get aColorableTerminal(enum)ColorableTerminal::lockto get aColorableTerminalLocked(enum)This cuts out the first step, making sure everything goes through
ColorableTerminal.