Skip to content

Conversation

@amejia1
Copy link

@amejia1 amejia1 commented Jan 7, 2026

…RIZATION_HEADER` environment variable.

This partially addresses #1343 by supporting reverse proxies which require authentication that function as mirrors to https://static.rust-lang.org .

…RIZATION_HEADER` environment variable.

This partially addresses rust-lang#1343 by supporting reverse proxies
which require authentication that function as mirrors to https://static.rust-lang.org .
@djc
Copy link
Contributor

djc commented Jan 7, 2026

If this is about a reverse proxy I don't think the complexity of doing this is worth it. Instead, it seems like the main issue is that we might leak credentials in logging when using RUSTUP_DIST_SERVER, which can be remedied more directly. We should also not unlink #1343 from this, because that issue seems to be about a forward proxy, not a reverse proxy.

@amejia1
Copy link
Author

amejia1 commented Jan 7, 2026

If this is about a reverse proxy I don't think the complexity of doing this is worth it. Instead, it seems like the main issue is that we might leak credentials in logging when using RUSTUP_DIST_SERVER, which can be remedied more directly. We should also not unlink #1343 from this, because that issue seems to be about a forward proxy, not a reverse proxy.

This change would also support token based authentication through the Bearer scheme. I had those in mind when I thought to implement these changes. Here are some examples of what I mean https://api.goauthentik.io/authentication/

@amejia1 amejia1 marked this pull request as draft January 8, 2026 03:55
@amejia1
Copy link
Author

amejia1 commented Jan 8, 2026

I have converted this PR to a draft. I need to investigate ways to start a forward proxy which requires authentication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants