-
Notifications
You must be signed in to change notification settings - Fork 276
Added bind_device_by_index_{v4,v6} for linux and android (#569) #572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f766329 to
931d818
Compare
931d818 to
5c81ff2
Compare
|
For Android and Linux, the syscalls are independent of the V4 or V6 stack used, therefore the function name should be Since Android support required a bump to PR 573 is created that resolves the issues listed. |
5c81ff2 to
4fc67a9
Compare
The question here is mainly if the socket2 library should provide an abstraction from the target OS (as far as possible) or provide a different set of functions for each target OS. I leave it to the maintainers of the socket2 library to make this decision.
Added. (Again, a decision from the socket2 maintainers is needed if this should be added to the existing
Updated. |
The question here is if the socket2 library should provide functions which abstract from the target OS (as far as possible) or if it should provide target OS specific functions. I.e. do we want to have I leave it to the maintainer of the socket2 library to make this decision.
Added. (Same as above: A decision is needed if we want to have
Updated. |
Thomasdezeeuw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for leaving this so long. I've made a small change to mention SO_BINDTOIFINDEX in the getter function, similar to what you already did in the setters.
|
Thanks @boris-n |
No description provided.