Skip to content

remove test --skip that references a long-closed issue #1670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2024
Merged

remove test --skip that references a long-closed issue #1670

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de0800e
remove test --skip that references a long-closed issue
RalfJung Nov 10, 2024
8032099
move wasm comment to a better place
RalfJung Nov 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions ci/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,21 +75,17 @@ cargo_test() {
cmd="$cmd ${subcmd} --target=$TARGET $1"
cmd="$cmd -- $2"

# wasm targets can't catch panics so if a test failures make sure the test
# harness isn't trying to capture output, otherwise we won't get any useful
# output.
case ${TARGET} in
# wasm targets can't catch panics so if a test failures make sure the test
# harness isn't trying to capture output, otherwise we won't get any useful
# output.
wasm32*)
cmd="$cmd --nocapture"
;;
# qemu has an erratic behavior on those tests
powerpc64*)
cmd="$cmd --skip test_vec_lde_u16 --skip test_vec_lde_u32 --skip test_vec_expte"
Comment on lines 85 to 87
Copy link
Member Author

@RalfJung RalfJung Nov 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue (on our side or for qemu) tracking this?
Cc @lu-zero

;;
# Miscompilation: https://github.com/rust-lang/rust/issues/112460
arm*)
cmd="$cmd --skip vld2q_dup_f32"
;;
esac

if [ "$SKIP_TESTS" != "" ]; then
Expand Down