Skip to content

Conversation

sayantn
Copy link
Contributor

@sayantn sayantn commented Aug 27, 2025

Except for these 44 functions that explicitly use f16 in the signature

  • _mm{,256,512}_{set,set1,setr}_ph
  • _mm_set_sh
  • _mm{,256,512}_{load,loadu,store,storeu}_ph
  • _mm_{load,mask_load,maskz_load,store,mask_store}_sh
  • _mm{,256,512}_reduce_{add,mul,min,max}_ph
  • _mm{,256,512}_cvtsh_h
  • _mm{,256}_bcstnesh_ps

Tracking issue: rust-lang/rust#127213

I also changed the feature parameter for these stabilized functions to be stdarch_x86_avx512fp16, as rustc doesn't allow a stable and unstable feature to have the same name

cc @tgross35

@rustbot
Copy link
Collaborator

rustbot commented Aug 27, 2025

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as far as what is getting stabilized here. This still requires the FCP at rust-lang/rust#127213.

I also changed the feature parameter for these stabilized functions to be stdarch_x86_avx512fp16, as rustc doesn't allow a stable and unstable feature to have the same name

It would probably be best to rename the stdarch_x86_avx512fp16_2 or something like that rather than having the only difference be an underscore. But that can happen separately.

@sayantn
Copy link
Contributor Author

sayantn commented Aug 27, 2025

It would probably be best to rename the stdarch_x86_avx512fp16_2 or something like that rather than having the only difference be an underscore. But that can happen separately.

The other feature name is stdarch_x86_avx512_f16 (not fp16), but I get your point lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants