Skip to content

crc32: remove #[cfg(not(target_arch = "arm"))] from aarch64 crc functions #1939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2025
Merged

crc32: remove #[cfg(not(target_arch = "arm"))] from aarch64 crc functions #1939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions crates/core_arch/src/aarch64/neon/generated.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ use super::*;
#[doc = "[Arm's documentation](https://developer.arm.com/architectures/instruction-sets/intrinsics/__crc32cd)"]
#[inline]
#[target_feature(enable = "crc")]
#[cfg(not(target_arch = "arm"))]
#[cfg_attr(test, assert_instr(crc32cx))]
#[stable(feature = "stdarch_aarch64_crc32", since = "1.80.0")]
pub fn __crc32cd(crc: u32, data: u64) -> u32 {
Expand All @@ -33,7 +32,6 @@ pub fn __crc32cd(crc: u32, data: u64) -> u32 {
#[doc = "[Arm's documentation](https://developer.arm.com/architectures/instruction-sets/intrinsics/__crc32d)"]
#[inline]
#[target_feature(enable = "crc")]
#[cfg(not(target_arch = "arm"))]
#[cfg_attr(test, assert_instr(crc32x))]
#[stable(feature = "stdarch_aarch64_crc32", since = "1.80.0")]
pub fn __crc32d(crc: u32, data: u64) -> u32 {
Expand Down
6 changes: 0 additions & 6 deletions crates/stdarch-gen-arm/spec/neon/aarch64.spec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@ auto_llvm_sign_conversion: false
neon-stable: &neon-stable
FnCall: [stable, ['feature = "neon_intrinsics"', 'since = "1.59.0"']]

# #[cfg(not(target_arch = "arm"))]
target-not-arm: &target-not-arm
FnCall: [cfg, [{ FnCall: [not, ['target_arch = "arm"']]}]]

# #[cfg(not(target_arch = "arm64ec"))]
target-not-arm64ec: &target-not-arm64ec
FnCall: [cfg, [{ FnCall: [not, ['target_arch = "arm64ec"']]}]]
Expand Down Expand Up @@ -13082,7 +13078,6 @@ intrinsics:
return_type: "{type[0]}"
attr:
- FnCall: [target_feature, ['enable = "crc"']]
- *target-not-arm
- FnCall: [cfg_attr, [test, { FnCall: [assert_instr, ["crc32x"]] }]]
- *aarch64-crc-stable
safety: safe
Expand All @@ -13104,7 +13099,6 @@ intrinsics:
return_type: "{type[0]}"
attr:
- FnCall: [target_feature, ['enable = "crc"']]
- *target-not-arm
- FnCall: [cfg_attr, [test, { FnCall: [assert_instr, ["crc32cx"]] }]]
- *aarch64-crc-stable
safety: safe
Expand Down