Disable AMD-specific intrinsic tests in the SDE run #1940
Merged
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amanieu
reviewed
Oct 11, 2025
| -rtm-mode full -tsx --" | ||
| # SDE doesn't support AMD extensions | ||
| # FIXME: find a way to test these | ||
| ENV STDARCH_TEST_SKIP_FEATURE="sse4a,tbm,xop" |
There was a problem hiding this comment.
Is this still needed with the modified cpuid? We should automatically skip tests for which we don't have the features.
There was a problem hiding this comment.
It will skip, but then it will fail due to STDARCH_TEST_EVERYTHING
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow these tests succeeded all this time, when SDE doesn't actually support AMD extensions at all
r? @Amanieu