Use declarative attribute macros instead of procedural macros for better compile times #1962
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we use 2 procedural macros,
assert_instrandsimd_test, for testing. It is convenient, but the problem is that it significantly slows down compilation. Seeing that these macros are pretty small, I thought of using declarative attribute macros (rust-lang/rust#143547) insteadThe diffcount is huge due to all uses of
simd_testbeing changed, likegot changed to
The reason being that we cannot do string splitting etc in declarative macros