Skip to content

Conversation

marcoieni
Copy link
Member

@marcoieni marcoieni commented Aug 11, 2025

This team contains people with elevated crates-io priviledges.
In a follow-up PR, I would like to give these people write access to https://github.com/rust-lang/crates-io-auth-action/ to solve rust-lang/crates-io-auth-action#13

Copy link

Dry-run check results

[WARN  sync_team] sync-team is running in dry mode, no changes will be applied.
[INFO  sync_team] synchronizing github
[INFO  sync_team] 💻 Team Diffs:
    ➕ Creating team:
      Org: rust-lang
      Name: crates-io-infra-admins
      Description: Managed by the rust-lang/team repository.
      Privacy: closed
      Members:
        LawnGnome: member
        Turbo87: member
        carols10cents: member
        jtgeibel: member

@jieyouxu jieyouxu added the T-infra Relevant to the infrastructure team. label Aug 12, 2025
Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this, but I wonder if this should also include the regular infra admins? can teams "inherit" members from other teams? 😅

@marcoieni
Copy link
Member Author

mmmh, I'm not sure how useful it is to add infra admins here as well. We can add it later if needed.

@marcoieni marcoieni marked this pull request as ready for review August 25, 2025 13:45
@marcoieni
Copy link
Member Author

can teams "inherit" members from other teams? 😅

btw, yes

included-teams = ["leadership-council", "leads", "project-group-leads", "foundation-board-project-directors"]

@marcoieni marcoieni requested a review from jieyouxu August 26, 2025 14:13
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was discussed in #1889 (comment) re. trusted publishing

A compromised account of a member of the crates.io team (at least one with Heroku access) could achieve the same thing by messing with the production deployment anyway. I think it's fine to give access to the crates.io team, or at least the subset of the crates.io team that has database access.

@jieyouxu jieyouxu added needs-team-repo-admin-review This change requires one of the `team-repo-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin. labels Aug 26, 2025
@jieyouxu jieyouxu added this pull request to the merge queue Aug 26, 2025
Merged via the queue into master with commit 1b59676 Aug 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-team-repo-admin-review This change requires one of the `team-repo-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin. T-infra Relevant to the infrastructure team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants