-
Notifications
You must be signed in to change notification settings - Fork 318
create the crates-io-infra-admins marker team #1943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create the crates-io-infra-admins marker team #1943
Conversation
Dry-run check results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving this, but I wonder if this should also include the regular infra admins? can teams "inherit" members from other teams? 😅
mmmh, I'm not sure how useful it is to add infra admins here as well. We can add it later if needed. |
btw, yes team/teams/inside-rust-reviewers.toml Line 7 in bd9df68
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was discussed in #1889 (comment) re. trusted publishing
A compromised account of a member of the crates.io team (at least one with Heroku access) could achieve the same thing by messing with the production deployment anyway. I think it's fine to give access to the crates.io team, or at least the subset of the crates.io team that has database access.
This team contains people with elevated crates-io priviledges.
In a follow-up PR, I would like to give these people write access to https://github.com/rust-lang/crates-io-auth-action/ to solve rust-lang/crates-io-auth-action#13