Ignore bors merge commits in issue links handler as nothing can be done #1944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
approved these changes
Apr 17, 2025
There was a problem hiding this comment.
Eventually, we should do something about the bors merge commit messages, but that's a task for new bors, and it will require a lot of modifications in several other repos 😅 And this is yet another place that we should eventually modify once we make the merge messages contain an absolute issue link 😁
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an ignore list of
@borsmerge commits as nothing can be done about them.Reported in miri rust-lang/miri#4259 (comment)