Add concern/resolve commands in an rfcbot-like manner
#2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
reviewed
May 28, 2025
| - [This is my concern about concern](https://github.com/fake-comment-1234) by [Urgau](https://github.com/Urgau) | ||
| - ~~[This is a resolved concern](https://github.com/fake-comment-4561) by [Kobzol](https://github.com/Kobzol)~~ resolved [in this comment](https:://github.com/fake-comment-8888) | ||
| Generated by triagebot, see [help](https://forge.rust-lang.org/triagebot/concern.html) for how to use them. |
There was a problem hiding this comment.
This should ideally be a pending/merged Forge PR before we merge this, I guess?
There was a problem hiding this comment.
Opened rust-lang/rust-forge#867 to document it.
Kobzol
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #triagebot > triagebot concern, this PR introduces two new commands:
@bot concern CONCERN TITLE: which registers a concern@bot resolve CONCERN TITLE: which marks a concern as resolvedThe goal is to be able to set concerns on issues/PRs, and in particular to compiler MCP, which currently uses an ad-hoc system of abusing
@rfcbotnon-response.The commands are feature-gated by a
[concern]table:below is what it would look like
Concerns
This is a resolved concern by Kobzolresolved in this commentGenerated by triagebot, see help for how to use them.