Skip to content

Update MCP concerns retrieval #2073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025
Merged

Update MCP concerns retrieval #2073

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/github.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2174,12 +2174,12 @@ impl<'q> IssuesQuery for Query<'q> {
}

/// Return open concerns filed in an issue under MCP/RFC process
/// Concerns are marked by `@rfcbot concern` and `@rfcbot resolve`
/// Concerns are marked by `@rustbot concern` and `@rustbot resolve`
fn find_open_concerns(comments: Vec<Comment>) -> Option<Vec<(String, String)>> {
let re_concern_raise =
Regex::new(r"@rfcbot concern (?P<concern_title>.*)").expect("Invalid regexp");
Regex::new(r"@rustbot concern (?P<concern_title>.*)").expect("Invalid regexp");
let re_concern_solve =
Regex::new(r"@rfcbot resolve (?P<concern_title>.*)").expect("Invalid regexp");
Regex::new(r"@rustbot resolve (?P<concern_title>.*)").expect("Invalid regexp");
let mut raised: HashMap<String, String> = HashMap::new();
let mut solved: HashMap<String, String> = HashMap::new();

Expand All @@ -2198,11 +2198,11 @@ fn find_open_concerns(comments: Vec<Comment>) -> Option<Vec<(String, String)>> {

// pick the first match only
if !r.is_empty() {
let x = r[0].replace("@rfcbot concern", "");
let x = r[0].replace("@rustbot concern", "");
raised.insert(x.trim().to_string(), comment.html_url.to_string());
}
if !s.is_empty() {
let x = s[0].replace("@rfcbot resolve", "");
let x = s[0].replace("@rustbot resolve", "");
solved.insert(x.trim().to_string(), comment.html_url.to_string());
}
}
Expand Down
Loading