Run Clippy

src/handlers/check_commits/issue_links.rs

@@ -1,3 +1,4 @@
+use std::fmt::Write;
 use std::sync::LazyLock;
 
 use regex::Regex;
@@ -30,8 +31,10 @@ pub(super) fn issue_links_in_commits(
                 .any(|i| c.commit.message.starts_with(i))
         })
         .filter(|c| does_match(&c.commit.message))
-        .map(|c| format!("- {}\n", c.sha))
-        .collect::<String>();
+        .fold(String::new(), |mut commits, c| {
+            _ = writeln!(commits, "- {}", c.sha);
+            commits
+        });
 
     if issue_links_commits.is_empty() {
         None

src/handlers/check_commits/no_mentions.rs

@@ -1,6 +1,8 @@
 //! Purpose: When opening a PR, or pushing new changes, check for github mentions
 //! in commits and notify the user of our no-mentions in commits policy.
 
+use std::fmt::Write;
+
 use crate::{config::NoMentionsConfig, github::GithubCommit};
 
 pub(super) fn mentions_in_commits(
@@ -22,8 +24,10 @@ pub(super) fn mentions_in_commits(
             let mentions = parser::get_mentions(&c.commit.message);
             !mentions.is_empty() && mentions.iter().any(|m| *m != "rustbot")
         })
-        .map(|c| format!("- {}\n", c.sha))
-        .collect::<String>();
+        .fold(String::new(), |mut commits, c| {
+            _ = writeln!(commits, "- {}", c.sha);
+            commits
+        });
 
     if mentions_commits.is_empty() {
         None

src/handlers/check_commits/no_merges.rs

@@ -53,7 +53,7 @@ fn get_default_message<'a>(
     default_branch: &str,
     commits: impl IntoIterator<Item = &'a str>,
 ) -> String {
-    let mut message = format!(
+    let mut message = String::from(
         "The following commits have merge commits (commits with multiple parents) in your changes. \
 We have a [no merge policy](https://rustc-dev-guide.rust-lang.org/git.html#no-merge-policy) \
 so these commits will need to be removed for this pull request to be merged.

src/handlers/ping.rs

@@ -4,6 +4,8 @@
 //!
 //! Parsing is done in the `parser::command::ping` module.
 
+use std::borrow::Cow;
+
 use crate::{
     config::PingConfig,
     github::{self, Event},
@@ -89,10 +91,10 @@ pub(super) async fn handle_command(
         }
     }
 
-    let ping_msg = if users.is_empty() {
-        format!("no known users to ping?")
+    let ping_msg: Cow<_> = if users.is_empty() {
+        "no known users to ping?".into()
     } else {
-        format!("cc {}", users.join(" "))
+        format!("cc {}", users.join(" ")).into()
     };
     let comment = format!("{}\n\n{}", config.message, ping_msg);
     event

src/handlers/types_planning_updates.rs

@@ -27,19 +27,17 @@ impl Job for TypesPlanningMeetingThreadOpenJob {
         if first_monday.month() == today.month() {
             return Ok(());
         }
-        let meeting_date_string = first_monday.format("%Y-%m-%d").to_string();
-        let message = format!(
-            "\
+        let meeting_date_string = first_monday.format("%Y-%m-%d");
+        let message = "\
             Hello @*T-types/meetings*. Monthly planning meeting in one week.\n\
             This is a reminder to update the current [roadmap tracking issues](https://github.com/rust-lang/types-team/issues?q=is%3Aissue+is%3Aopen+label%3Aroadmap-tracking-issue).\n\
-            Extra reminders will be sent later this week."
-        );
+            Extra reminders will be sent later this week.";
         let zulip_req = crate::zulip::MessageApiRequest {
             recipient: Recipient::Stream {
                 id: TYPES_MEETINGS_STREAM,
                 topic: &format!("{meeting_date_string} planning meeting"),
             },
-            content: &message,
+            content: message,
         };
         zulip_req.send(&ctx.zulip).await?;
 
@@ -51,7 +49,7 @@ impl Job for TypesPlanningMeetingThreadOpenJob {
         let noon = NaiveTime::from_hms_opt(12, 0, 0).unwrap();
         let thursday_at_noon = Utc.from_utc_datetime(&thursday.and_time(noon));
         let metadata = serde_json::value::to_value(PlanningMeetingUpdatesPingMetadata {
-            date_string: meeting_date_string,
+            date_string: meeting_date_string.to_string(),
         })
         .unwrap();
         schedule_job(

src/notification_listing.rs

@@ -1,3 +1,4 @@
+use std::fmt::Write;
 use std::sync::Arc;
 
 use anyhow::Context as _;
@@ -39,15 +40,16 @@ pub async fn notifications(
     out.push_str("</head>");
     out.push_str("<body>");
 
-    out.push_str(&format!("<h3>Pending notifications for {}</h3>", user));
+    _ = write!(out, "<h3>Pending notifications for {user}</h3>");
 
     if notifications.is_empty() {
         out.push_str("<p><em>You have no pending notifications! :)</em></p>");
     } else {
         out.push_str("<ol>");
         for notification in notifications {
             out.push_str("<li>");
-            out.push_str(&format!(
+            _ = write!(
+                out,
                 "<a href='{}'>{}</a>",
                 notification.origin_url,
                 notification
@@ -59,17 +61,18 @@ pub async fn notifications(
                     .replace('>', "&gt;")
                     .replace('"', "&quot;")
                     .replace('\'', "&#39;"),
-            ));
+            );
             if let Some(metadata) = &notification.metadata {
-                out.push_str(&format!(
+                _ = write!(
+                    out,
                     "<ul><li>{}</li></ul>",
                     metadata
                         .replace('&', "&amp;")
                         .replace('<', "&lt;")
                         .replace('>', "&gt;")
                         .replace('"', "&quot;")
                         .replace('\'', "&#39;"),
-                ));
+                );
             }
             out.push_str("</li>");
         }

src/zulip.rs

@@ -814,8 +814,9 @@ async fn acknowledge(
     } else {
         let mut resp = String::from("Acknowledged:\n");
         for deleted in deleted {
-            resp.push_str(&format!(
-                " * [{}]({}){}\n",
+            _ = writeln!(
+                resp,
+                " * [{}]({}){}",
                 deleted
                     .short_description
                     .as_deref()
@@ -824,7 +825,7 @@ async fn acknowledge(
                 deleted
                     .metadata
                     .map_or(String::new(), |m| format!(" ({m})")),
-            ));
+            );
         }
         resp
     };