Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
daa1e8d
Add Nix flake
ada4a Sep 13, 2025
f82b3c2
parser: bump edition to 2024
ada4a Sep 13, 2025
deb5439
unused/elidable lifetimes
ada4a Sep 14, 2025
5b2c130
redundant refs/derefs
ada4a Sep 14, 2025
8a7c9f7
clippy::uninlined_format_args
ada4a Sep 14, 2025
b094757
clippy::if_not_else
ada4a Sep 14, 2025
659d85e
clippy::needless_return
ada4a Sep 14, 2025
8df056e
explicit iterator loops
ada4a Sep 14, 2025
52d5270
clippy::useless_conversion
ada4a Sep 16, 2025
258e3b7
simplify thanks to the previous commit
ada4a Sep 16, 2025
60602d0
simplify `match`es
ada4a Sep 13, 2025
88731ed
use `std::iter::zip`
ada4a Sep 15, 2025
82259d8
clippy::inefficient_to_string
ada4a Sep 15, 2025
ef55ea7
clippy::ignored_unit_patterns
ada4a Sep 15, 2025
69cb114
derive `Default` for `IssueLinksCheckCommitsConfig`
ada4a Sep 15, 2025
8760f36
use more idiomatic iterator/`Option` adaptors
ada4a Sep 15, 2025
32ea017
clean-up consts
ada4a Sep 15, 2025
778ba02
use `let-else`
ada4a Sep 15, 2025
031aa5d
clippy::cast_lossless
ada4a Sep 15, 2025
554289e
documentation lints
ada4a Sep 15, 2025
d978fc5
reborrow instead of slicing
ada4a Sep 15, 2025
d15c931
add/remove semicolons
ada4a Sep 15, 2025
b331922
clippy::write_with_newline
ada4a Sep 15, 2025
38ba2dd
clippy::manual_string_new
ada4a Sep 15, 2025
c27e100
clippy::single_char_pattern
ada4a Sep 15, 2025
9989a85
clippy::implicit_clone
ada4a Sep 15, 2025
93a80e0
get `command` without unwrapping
ada4a Sep 15, 2025
1da5e71
`write!` _inside_ `match`
ada4a Sep 15, 2025
e2903b5
clippy::unneded_struct_pattern
ada4a Sep 15, 2025
01d4d27
clippy::manual_strip
ada4a Sep 15, 2025
867b95f
clippy::manual_assert
ada4a Sep 15, 2025
d92c33d
needless `into_iter`
ada4a Sep 14, 2025
7d729ff
clippy::legacy_numeric_constants
ada4a Sep 14, 2025
8372962
clippy::inconsistent_struct_constructor
ada4a Sep 14, 2025
efdd2a8
clippy::redundant_closure_for_method_calls
ada4a Sep 14, 2025
f846986
clippy::manual_is_variant_and
ada4a Sep 14, 2025
6ba8cc3
clippy::needless_raw_string_hashes
ada4a Sep 14, 2025
5ed9adf
clippy::question_mark
ada4a Sep 14, 2025
41bde06
construct `HashMap` from array
ada4a Sep 14, 2025
bc1d4ab
clippy::collapsible{,_else}_if
ada4a Sep 14, 2025
ea0801a
use `Result::ok_or` for trying out multiple things
ada4a Sep 14, 2025
05ecbd4
use `as_deref` to avoid allocating a String
ada4a Sep 15, 2025
2d19376
`RustcFormat::store_version`: take params by reference
ada4a Sep 14, 2025
4ea6b20
`config`: introduce `MaybeConfig` type alias
ada4a Sep 14, 2025
42e4037
avoid eager/useless `format!`s
ada4a Sep 14, 2025
8018914
replace `std::iter::once(_)` with `[_]`
ada4a Sep 14, 2025
93ad1fa
use `Itertools::format`
ada4a Sep 14, 2025
5930e34
replace `.ok_or_else(|| anyhow::anyhow!` with `.context(`
ada4a Sep 14, 2025
3a1133f
don't destructure tuple for comparison
ada4a Sep 14, 2025
929f3d4
`expect` some lints
ada4a Sep 16, 2025
cee3a6a
clippy::field_reassign_with_default
ada4a Sep 16, 2025
284ba8c
clippy::vec_init_then_push
ada4a Sep 16, 2025
ac4d7df
avoid `clippy::partialeq_to_none`
ada4a Sep 16, 2025
b722c5f
clippy::manual_find
ada4a Sep 16, 2025
4382423
clippy::ptr_arg
ada4a Sep 16, 2025
7443c6c
deref `Label` to `&str` directly
ada4a Sep 16, 2025
8031a82
clippy::redundant_pattern_matching
ada4a Sep 16, 2025
9b541d0
lints on FCP-related items
ada4a Sep 16, 2025
45d88f8
clippy::unused_self
ada4a Sep 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion parser/src/command.rs
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ impl<'a> Input<'a> {
pub fn new(input: &'a str, bot: Vec<&'a str>) -> Input<'a> {
let bots: Vec<_> = bot.iter().map(|bot| format!(r"(?:@{bot}\b)")).collect();
let bot_re = Regex::new(&format!(
r#"(?i)(?P<review>\br\?)|{bots}"#,
r"(?i)(?P<review>\br\?)|{bots}",
bots = bots.join("|")
))
.unwrap();
Expand Down
4 changes: 2 additions & 2 deletions src/gh_range_diff.rs
Original file line number Diff line number Diff line change
Expand Up @@ -408,10 +408,10 @@ fn process_old_new(

writeln!(
html,
r#"
r"
</body>
</html>
"#
"
)?;

let mut headers = HeaderMap::new();
Expand Down
4 changes: 2 additions & 2 deletions src/handlers/check_commits/force_push_range_diff.rs
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,9 @@ fn changed_base_commit(
let newbase = &compare_after.merge_base_commit.sha;

let message = format!(
r#"This PR was rebased onto a different {branch} commit. Here's a [range-diff]({protocol}://{host}/gh-range-diff/{issue_repo}/{oldbase}..{oldhead}/{newbase}..{newhead}) highlighting what actually changed.
r"This PR was rebased onto a different {branch} commit. Here's a [range-diff]({protocol}://{host}/gh-range-diff/{issue_repo}/{oldbase}..{oldhead}/{newbase}..{newhead}) highlighting what actually changed.

*Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.*"#
*Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.*"
);

Some(message)
Expand Down
50 changes: 25 additions & 25 deletions src/handlers/major_change.rs
Original file line number Diff line number Diff line change
Expand Up @@ -382,29 +382,29 @@ async fn handle(
if new_proposal {
let topic_url = zulip_req.url(&ctx.zulip);
let comment = format!(
r#"> [!IMPORTANT]
> This issue is *not meant to be used for technical discussion*. There is a **Zulip [stream]** for that.
> Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

<details>
<summary>Concerns or objections can formally be registered here by adding a comment.</summary>
<p>

```
@rustbot concern reason-for-concern
<description of the concern>
```
Concerns can be lifted with:
```
@rustbot resolve reason-for-concern
```
See documentation at [https://forge.rust-lang.org](https://forge.rust-lang.org/compiler/proposals-and-stabilization.html#what-kinds-of-comments-should-go-on-a-mcp-in-the-compiler-team-repo)

</p>
</details>
{}

[stream]: {topic_url}"#,
r"> [!IMPORTANT]
> This issue is *not meant to be used for technical discussion*. There is a **Zulip [stream]** for that.
> Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

<details>
<summary>Concerns or objections can formally be registered here by adding a comment.</summary>
<p>

```
@rustbot concern reason-for-concern
<description of the concern>
```
Concerns can be lifted with:
```
@rustbot resolve reason-for-concern
```
See documentation at [https://forge.rust-lang.org](https://forge.rust-lang.org/compiler/proposals-and-stabilization.html#what-kinds-of-comments-should-go-on-a-mcp-in-the-compiler-team-repo)

</p>
</details>
{}

[stream]: {topic_url}",
config.open_extra_text.as_deref().unwrap_or_default(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this actually the same thing? The other ones were not indented.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, no, sorry, that's an annoying bug in the Git merge driver that I'm co-developing – I really should get to fixing it...

);
issue
Expand Down Expand Up @@ -683,11 +683,11 @@ async fn process_seconded(
.post_comment(
&ctx.github,
&format!(
r#"The final comment period is now complete, this major change is now **accepted**.
r"The final comment period is now complete, this major change is now **accepted**.

As the automated representative, I would like to thank the author for their work and everyone else who contributed to this major change proposal.

*If you think this major change shouldn't have been accepted, feel free to remove the `{}` label and reopen this issue.*"#,
*If you think this major change shouldn't have been accepted, feel free to remove the `{}` label and reopen this issue.*",
&config.accept_label,
),
)
Expand Down
2 changes: 1 addition & 1 deletion src/handlers/project_goals.rs
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ pub async fn handle(ctx: &Context, event: &Event) -> anyhow::Result<()> {
topic: &zulip_topic_name,
},
content: &format!(
r#"New tracking issue goals#{goalnum}.\n* Goal title: {title}\n* Goal owners: {zulip_owners}"#
r"New tracking issue goals#{goalnum}.\n* Goal title: {title}\n* Goal owners: {zulip_owners}"
),
};
zulip_req.send(&ctx.zulip).await?;
Expand Down