Skip to content

Conversation

bluss
Copy link
Member

@bluss bluss commented Nov 23, 2024

Based on #379. Opened new PR to run tests again, need to see their status and logs.

@Dirreke
Copy link
Collaborator

Dirreke commented Nov 23, 2024

I think we need merge #372 first, and then bump MSRV.

@bluss bluss force-pushed the bluss/bump-ndarray branch from 353d342 to 91846a0 Compare November 24, 2024 01:00
@cguentherTUChemnitz
Copy link

When i understand correctly, there is just the MSRV bump missing, what @Dirreke already pointed to. At least the one red job of CI is complaining about exactly that:

error: package `idna_adapter v1.2.0` cannot be built because it requires rustc 1.67.0 or newer, while the currently active rustc version is 1.63.0

@cguentherTUChemnitz
Copy link

I tried to add just the missing commit here, to update the rust versions of the CI runners. I did not find a way to add it to the existing pull-request, so i created a new one: #389

@Dirreke Dirreke mentioned this pull request Dec 14, 2024
@Dirreke
Copy link
Collaborator

Dirreke commented Dec 16, 2024

Before we discuss MSRV, let’s rebase this PR, rerun the CI, and merge it first. Afterward, we can decide MSRV and add an MSRV test to the CI.

@cguentherTUChemnitz
Copy link

This request can be closed, since #389 is already merged and contains the same commits.

@bluss bluss closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants