Reduce instantiated code (measured by cargo llvm-lines) #1004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Factor out the code that checks C/F memory layout into standalone functions. These functions will be more useful on their own. Also factor out the NdProducer Layout computation function, so that more of that code is shared between generic instatiations. Tested using cargo llvm-lines.
Debloat by pushing the code down into the DataReprs, this avoids instantiating the pointer check code for the views (where it can't do anything anyway).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used cargo llvm-lines with the examples, and factored out some functionality so that it
can be shared better between different generic instantiations.
This also deprecates (but does not remove) the method
RawData::_data_slicesince it could in theory be in use by someone, even if it's not public API.