Skip to content

uefi: Add panic doc to uefi::helpers::init #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2024
Merged

uefi: Add panic doc to uefi::helpers::init #1391

merged 1 commit into from
Sep 3, 2024

Conversation

nicholasbishop
Copy link
Member

This function may panic if called more than once, because log::set_logger panics if called more than once. Document this panic.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@nicholasbishop
uefi: Add panic doc to uefi::helpers::init
1cc3189 
This function may panic if called more than once, because `log::set_logger`
panics if called more than once. Document this panic.
@nicholasbishop nicholasbishop mentioned this pull request Sep 3, 2024
Merged
@phip1611 phip1611 added this pull request to the merge queue Sep 3, 2024
Merged via the queue into rust-osdev:main with commit 9090f9e Sep 3, 2024
14 checks passed
@nicholasbishop nicholasbishop deleted the bishop-helper-init-doc branch September 3, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phip1611 phip1611 phip1611 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nicholasbishop @phip1611