uefi-macros: Require that the entry function takes zero args #1418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor cleanup; a method usually refers to a function in an impl, not a free-standing function like `main`.
Also delete the two unnamed arg tests, those will no longer be relevant after the next commit when `entry` will require a zero-arg function. Leave the entry_bad_arg test unmodified for now, as it will need additional changes in the next commit.
The entry function is now required to have zero arguments.
2 tasks
phip1611
reviewed
Oct 1, 2024
| // Fill in the image handle and system table arguments automatically. | ||
| let image_handle_ident = quote!(internal_image_handle); | ||
| let system_table_ident = quote!(internal_system_table); | ||
| f.sig.inputs = parse_quote_spanned!( |
There was a problem hiding this comment.
nice, thanks for working on this!
(I'm always happy if I do not have to write codegen code by myself.. its tricky 😀)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also drops all use of deprecated SystemTable struct from macro tests.
Checklist