uefi: Add CStr16 conversions from slices with interior nuls #1422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is modeled after `CStr::from_bytes_until_nul`, which was added in Rust 1.69. It's often the case that you have a slice of data containing a string, but the buffer size is larger than the string; these new methods make that case easy to handle. [1]: https://doc.rust-lang.org/std/ffi/struct.CStr.html#method.from_bytes_until_nul
nicholasbishop
force-pushed
the
bishop-until-nul
branch
from
565c3c6 to
25b3dc0
Compare
phip1611
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is modeled after
CStr::from_bytes_until_nul, which was added in Rust 1.69. It's often the case that you have a slice of data containing a string, but the buffer size is larger than the string; these new methods make that case easy to handle.Checklist