Use ovmf-prebuilt #1454
Merged
Use ovmf-prebuilt #1454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasbishop
force-pushed
the
bishop-use-ovmf-prebuilt-api
branch
from
94ddf59 to
bd11d37
Compare
This currently doesn't do anything, but in the next commit ovmf-prebuilt will be used to download OVMF files, and that library uses the logger.
This allows some code and dependencies to be deleted.
nicholasbishop
force-pushed
the
bishop-use-ovmf-prebuilt-api
branch
from
bd11d37 to
98d1ed2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies xtask/qemu.rs a bit.
Also install a simple logger in
main, so that download messages from ovmf-prebuilt get printed.For now I've kept the same edk2 tag, because the latest version is crashing QEMU in our CI. I'll follow up on that later to figure out why.
Checklist