Clean up some use of unsafe in MemoryMapRefMut #1483
Merged
+15
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The qsort, partition, and swap methods do not need to be `unsafe`; they do some unsafe operations internally, but have safe interfaces. Add some asserts to ensure that arguments passed to swap and get_element_phys_addr are valid, and also add some safety comments.
phip1611
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The qsort, partition, and swap methods do not need to be
unsafe; they do some unsafe operations internally, but have safe interfaces.Add some asserts to ensure that arguments passed to swap and get_element_phys_addr are valid, and also add some safety comments.
Checklist