Skip to content

Conversation

nicholasbishop
Copy link
Member

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

Previously this was sysv64. As of Rust 1.83, this is rejected by the compiler as
incompatible with an i386 target.
@nicholasbishop nicholasbishop changed the title Fix clippy::needless_lifetimes in Rust 1.83 Fix clippy::needless_lifetimes in Rust 1.83 and ShimLock ABI on ia32 Nov 28, 2024
@nicholasbishop
Copy link
Member Author

I'm not 100% sure that cdecl is what we want for ShimLock on ia32; the Rust docs are rather sparse, and shim doesn't document the protocol's ABI at all. But it at least compiles, which is better than sysv64.

@nicholasbishop
Copy link
Member Author

Merging to unblock CI

@nicholasbishop nicholasbishop added this pull request to the merge queue Dec 9, 2024
Merged via the queue into rust-osdev:main with commit c001431 Dec 9, 2024
15 checks passed
@nicholasbishop nicholasbishop deleted the bishop-fix-183 branch December 9, 2024 18:11
@phip1611
Copy link
Member

Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants