Skip to content

Add warning to custom memory types #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Add warning to custom memory types #1526

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3eee2cd
docs: add warning to custom memory type
hannahfluch Jan 24, 2025
6fdbd7d
docs: extend warning for custom memory type
hannahfluch Jan 24, 2025
a3269af
docs: use proper formatting
hannahfluch Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions uefi-raw/src/table/boot.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,7 @@ impl MemoryType {

/// Construct a custom `MemoryType`. Values in the range `0x8000_0000..=0xffff_ffff` are free for use if you are
/// an OS loader.
/// Warning* Some EFI firmware versions (e.g., OVMF r11337) may crash or [behave incorrectly](<https://wiki.osdev.org/UEFI#My_bootloader_hangs_if_I_use_user_defined_EFI_MEMORY_TYPE_values>) when using a custom `MemoryType`.
#[must_use]
pub const fn custom(value: u32) -> Self {
assert!(value >= 0x80000000);
Expand Down