Fix uefi-raw MSRV build, and improve CI for MSRV #1542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`size_of` wasn't added to the prelude until 1.80, but the uefi-raw MSRV is currently 1.70.
nicholasbishop
force-pushed
the
bishop-test-raw-msrv
branch
from
bd782ec to
60a4e18
Compare
Delete msrv_toolchain.toml, and instead read the MSRV from cargo and copy it to rust-toolchain.toml. This ensures the job is checking the same MSRV set in Cargo.toml, and reduces the number of places that the MSRV needs to be manually updated when we change it.
The `uefi-raw` package has a lower MSRV than the `uefi` package, so it needs to be tested separately.
nicholasbishop
force-pushed
the
bishop-test-raw-msrv
branch
from
60a4e18 to
482c0f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uefi-rawhas a lower MSRV than theuefipackage, currently 1.70. Fix a minor error that prevented it from building at that MSRV, and add a job to check that package's MSRV build going forward.Also improve the existing MSRV job so that it uses cargo to get the correct MSRV value, rather than having a separate MSRV toolchain file that has to be updated manually.
Checklist