Skip to content

uefi: Fix the BufferSize argument in SimpleNetwork::transmit #1550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2025
Merged

uefi: Fix the BufferSize argument in SimpleNetwork::transmit #1550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions uefi/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
- `boot::memory_map()` will never return `Status::BUFFER_TOO_SMALL` from now on,
as this is considered a hard internal error where users can't do anything
about it anyway. It will panic instead.
- `SimpleNetwork::transmit` now passes the correct buffer size argument.
Previously it incorrectly added the header size to the buffer length, which
could cause the firmware to read past the end of the buffer.


# uefi - 0.34.1 (2025-02-07)
Expand Down
2 changes: 1 addition & 1 deletion uefi/src/proto/network/snp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ impl SimpleNetwork {
(self.transmit)(
self,
header_size,
buffer.len() + header_size,
buffer.len(),
buffer.as_ptr().cast(),
src_addr.as_ref(),
dest_addr.as_ref(),
Expand Down