-
-
Notifications
You must be signed in to change notification settings - Fork 183
helpers: Add AlignedBuffer #1600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
As mentioned in #1595 (comment), let's move to the |
phip1611
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your many contributions and your patience! I left a few remarks.
If you resolve them, we are good to go
|
Hm. The |
|
Probably due to 1.86 going stable recently. If you want to, please put up a separate pr with fixes for those lints. Or I can do it sometime this weekend probably. |
phip1611
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now!
AlignedBuffer is a helper class that manages the livetime of a memory region, allocated using a certain alignment. Like Box, it handles deallocation when the object isn't used anymore.
AlignedBuffer is a helper class that manages the livetime of a memory region, allocated using a certain alignment. Like Box, it handles deallocation when the object isn't used anymore.
Checklist