uefi: change Fn closure to FnMut
#1662
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Could you please briefly describe why this is necessary and what wasn't possible before that change? |
|
| /// Call `f` with a slice of [`ConfigTableEntry`]. Each entry provides access to | ||
| /// a vendor-specific table. | ||
| pub fn with_config_table<F, R>(f: F) -> R | ||
| pub fn with_config_table<F, R>(mut f: F) -> R |
There was a problem hiding this comment.
Please document these changes in the changelog
|
Not sure why this PR has attracted an absolute flood of spambots. I blocked a few but there are a ton of accounts spamming us. |
Instead of a generic "forbidden type of item" error, recommend using the `newtype_enum!` macro.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist