Skip to content

Conversation

phip1611
Copy link
Member

@phip1611 phip1611 commented Jun 24, 2025

Follow-up of #1709

I think this should be sufficient. Once we merge, our "auto release CI magic" should take care of everything.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@phip1611 phip1611 requested a review from nicholasbishop June 24, 2025 07:24
@phip1611 phip1611 mentioned this pull request Jun 24, 2025
3 tasks
@nicholasbishop
Copy link
Member

nicholasbishop commented Jun 24, 2025

The commit message will need to start with release: (see example), otherwise the release flow won't trigger.

But otherwise, lgtm

@nicholasbishop
Copy link
Member

nicholasbishop commented Jun 25, 2025

Just noticed that this won't work because uefi-services isn't in this list: https://github.com/rust-osdev/uefi-rs/blob/main/.github/workflows/release.yml#L19

(It might be easier to just release this one manually with cargo publish -p uefi-services?)

@phip1611
Copy link
Member Author

phip1611 commented Jun 25, 2025

Okay; will do it manually today

@phip1611 phip1611 closed this Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants