EFI Shell Interface: CurDir Functions #1740
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 tasks
phip1611
reviewed
Aug 12, 2025
uefi/src/proto/shell/mod.rs
Outdated
| @@ -2,12 +2,141 @@ | |||
|
|
|||
| //! EFI Shell Protocol v2.2 | |||
|
|
|||
| use crate::proto::unsafe_protocol; | |||
| #![cfg(feature = "alloc")] | |||
There was a problem hiding this comment.
For module-wide restrictions, we prefer:
#[cfg(feature = "alloc")]
mod shell;
on the upper level instead.
There was a problem hiding this comment.
also it doesn't look to me that set_dir and get_dir need alloc at all
phip1611
reviewed
Aug 12, 2025
uefi/src/proto/shell/mod.rs
Outdated
| /// * `Some(Vec<env_names>)` - Vector of environment variable names | ||
| /// * `None` - Environment variable doesn't exist | ||
| #[must_use] | ||
| pub fn get_env<'a>(&'a self, name: Option<&CStr16>) -> Option<Vec<&'a CStr16>> { |
There was a problem hiding this comment.
i think this accidentally hit the PR.? should be part of #1679 ?
This commit implements wrappers for the following EFI Shell Protocol functions: set_cur_dir() and get_cur_dir().
This commit includes tests for the following EFI Shell Protocol functions: get_cur_dir() and set_cur_dir().
…h standard convention
RenTrieu
force-pushed
the
enhancement/efi_shell_interface_cur_dir
branch
from
4bef474 to
873e382
Compare
|
Hi Philipp. Thanks for catching these! It looks like when rebasing the commits, although I removed references to the other PR from the commit messages I neglected to do so from the code in all but the most recent commit. I've addressed it now and will also do so shortly for #1679. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the wrappers for the
GetCurDirandSetCurDirEFI Shell Protocol functions as part of the effort to address #448 .Checklist