uefi: Add bindings for the HII_CONFIG_ROUTING protocol#1753
uefi: Add bindings for the HII_CONFIG_ROUTING protocol#1753phip1611 merged 8 commits intorust-osdev:mainfrom
Conversation
6380ed3 to
2e556f1
Compare
2e556f1 to
0c54e18
Compare
phip1611
left a comment
There was a problem hiding this comment.
I reviewed everything and it LGTM! Thanks for working on this :) Left a few nits. Please answer my comments and then we are good to go
2977208 to
ef2b00d
Compare
|
please rebase, then I think we should be good to go :) |
ef2b00d to
b8609c9
Compare
|
Will do a final review tomorrow |
0c7b3cd to
33dc406
Compare
|
Could you please move the additions to |
phip1611
left a comment
There was a problem hiding this comment.
LGTM, will merge once the pre-requisite in aligned_buffer.rs is moved into a dedicated PR.
33dc406 to
f0cb7d9
Compare
| Name, | ||
| /// UEFI ConfigurationString {PathHdr} element | ||
| Path, | ||
| /// UEFI ConfigurationString {DescHdr} element |
There was a problem hiding this comment.
out of curiosity: What does this {} syntax refer to?
There was a problem hiding this comment.
I somehow wanted to illustrate that "DescHdr" is the name of an entity, declared in the UEFI spec.
The real name is <DescHdr>, but the CI didn't let me write that :(
https://uefi.org/sites/default/files/resources/UEFI_Spec_Final_2.11.pdf
Page 1803
- 35.2.1.1 Basic forms
- 35.2.1.2 Types
- 35.2.1.3 Routing elements
f0cb7d9 to
ea5b01d
Compare
I still had this lying around as experiment.
Polished it up a bit for the merge request.
It's best to review this commit-by-commit.
Checklist