uefi: add boot::[un_]install_multiple_protocol_interface() #1856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
force-pushed
the
install-protocol-interface
branch
3 times, most recently
from
74dd331 to
e34f624
Compare
The majority of our protocol-related public functions use a generic approach with `<P: ProtocolPointer + ?Sized>`. Unfortunately: - we are inconsistent with that - this hinders some use-cases where the GUID is only known at runtime Therefore, this is the first commit of a series of commits that improves the situation by providing base functions that use the generic-based API and `by_guid` counterparts for more runtime- flexibility.
Having these functions is very helpful if one installs multiple protocol interfaces in a driver at once. The caveat is unfortunately that Rust handling of varargs isn't very convenient. I also didn't come up with a working + nice way using normal macros to workaround. Instead, I looked into the implementation in edk2 [0]. The logic is fairly simple and can be emulated on a higher-level by us. [0] https://github.com/tianocore/edk2/blob/66346d5edeac2a00d3cf2f2f3b5f66d423c07b3e/MdeModulePkg/Core/Dxe/Hand/Handle.c#L630
phip1611
force-pushed
the
install-protocol-interface
branch
from
e34f624 to
8820a0e
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ultimately adds and tests
boot::install_multiple_protocol_interface()andboot::uninstall_multiple_protocol_interface()(see #302). Further, it streamlines multiple things and adds pre-requisites:<P: ProtocolPointer + ?Sized>and sometimesproto: &Guid_by_guidcounterpartsinstall_multiple_protocol_interface()Checklist