feat: add traditional mem balloon device #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution :) please resolve the conflicts by rebasing your branch |
mkroening
requested changes
Sep 3, 2025
| #[derive(VolatileFieldAccess)] | ||
| #[repr(C)] | ||
| pub struct Config { | ||
| #[access(ReadOnly)] // TODO: Not actually specified by the spec? |
There was a problem hiding this comment.
I think we can safely remove the TODO, right? Every time this field is mentioned in the spec, the driver reads it. It would also not make sense to make this driver-writable in the grand scheme of things.
Suggested change
| #[access(ReadOnly)] // TODO: Not actually specified by the spec? | |
| #[access(ReadOnly)] |
Comment on lines
+542
to
+544
| /// Deflate of the balloon is always? permitted on guest out of memory condition. | ||
| /// | ||
| /// TODO: Spec is a bit confusing on this feature, see <https://github.com/oasis-tcs/virtio-spec/issues/228> |
There was a problem hiding this comment.
Let's stick to the spec first and add notes afterwards:
Suggested change
| /// Deflate of the balloon is always? permitted on guest out of memory condition. | |
| /// | |
| /// TODO: Spec is a bit confusing on this feature, see <https://github.com/oasis-tcs/virtio-spec/issues/228> | |
| /// Deflate balloon on guest out of memory condition. | |
| /// | |
| /// <div class="warning"> | |
| /// | |
| /// The specification is a bit confusing on this feature, see [oasis-tcs/virtio-spec#228](https://github.com/oasis-tcs/virtio-spec/issues/228). | |
| /// | |
| /// </div> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the Traditional Memory Balloon Device based on VIRTIO v1.2